Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Unify compose file for services #18

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

StefanNemeth
Copy link
Contributor

Motivation

It was rather cumbersome to set up the whole project, requiring the developer to go into different folders with seperate compose files.

Description

Unify the compose setup into one file and document it in the respective directories.

Checklist

General

Server

  • Code is performant and follows best practices
  • I documented the Java code using JavaDoc style.

Client

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

@StefanNemeth StefanNemeth requested a review from a team as a code owner November 12, 2024 11:08
@StefanNemeth StefanNemeth changed the title Unify compose file for services build: Unify compose file for services Nov 12, 2024
Copy link
Contributor

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanNemeth StefanNemeth merged commit a420200 into main Nov 12, 2024
3 of 4 checks passed
@StefanNemeth StefanNemeth deleted the initial/improve-docs branch November 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants