From c8aca80afdd40d68395dc751d83ffa648757e889 Mon Sep 17 00:00:00 2001 From: CCS Operator Account Date: Thu, 3 Sep 2020 18:46:44 -0700 Subject: [PATCH 1/5] shorten shutter open duration to get accurate opening duration determined by empirically --- lib/bot_bench.py | 2 +- lib/pd.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/bot_bench.py b/lib/bot_bench.py index 60f3391..20f1214 100755 --- a/lib/bot_bench.py +++ b/lib/bot_bench.py @@ -33,7 +33,7 @@ def openShutter(exposure): sanityCheck() print "Open shutter for %s seconds" % exposure a=time.time() - bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure))) + bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1-5/800)))) b=time.time() time.sleep(0.03*exposure) c=time.time() diff --git a/lib/pd.py b/lib/pd.py index 608e10a..7e78593 100755 --- a/lib/pd.py +++ b/lib/pd.py @@ -56,7 +56,7 @@ def __init__(self, exposure, max_reads=2048): Maximum number of reads of monitoring photodiode. Default: 2048. """ - buffertime = exptime*5./800.+2 + buffertime = 1.0 # for exposures over 0.5 sec, nominal PD readout at 60Hz, From 80d3f648fc0ab475f449348f4193ece8ff2f301b Mon Sep 17 00:00:00 2001 From: CCS Operator Account Date: Thu, 3 Sep 2020 18:55:57 -0700 Subject: [PATCH 2/5] shorten shutter open duration to get accurate opening duration determined by empirically --- lib/bot_bench.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bot_bench.py b/lib/bot_bench.py index 20f1214..8cb1ce7 100755 --- a/lib/bot_bench.py +++ b/lib/bot_bench.py @@ -33,7 +33,7 @@ def openShutter(exposure): sanityCheck() print "Open shutter for %s seconds" % exposure a=time.time() - bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1-5/800)))) + bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1.-5/800)))) b=time.time() time.sleep(0.03*exposure) c=time.time() From 3b97aa2d06318a3d5cdc270933516abedea45a9d Mon Sep 17 00:00:00 2001 From: CCS Operator Account Date: Thu, 3 Sep 2020 21:53:08 -0700 Subject: [PATCH 3/5] Made the buffertime to 3 sec follwoing the Seth's recommendation --- lib/pd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pd.py b/lib/pd.py index 7e78593..3145769 100755 --- a/lib/pd.py +++ b/lib/pd.py @@ -56,7 +56,7 @@ def __init__(self, exposure, max_reads=2048): Maximum number of reads of monitoring photodiode. Default: 2048. """ - buffertime = 1.0 + buffertime = 3.0 # for exposures over 0.5 sec, nominal PD readout at 60Hz, From 37f87f619d850d6279a309ce6ebfb8f0bba3a891 Mon Sep 17 00:00:00 2001 From: CCS Operator Account Date: Fri, 4 Sep 2020 11:31:43 -0700 Subject: [PATCH 4/5] increased comments --- lib/bot_bench.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bot_bench.py b/lib/bot_bench.py index 8cb1ce7..70e2469 100755 --- a/lib/bot_bench.py +++ b/lib/bot_bench.py @@ -32,8 +32,9 @@ def setSpotFilter(filter): def openShutter(exposure): sanityCheck() print "Open shutter for %s seconds" % exposure + print "Actual open time to tell the shutter is %d seconds" % int(1000*exposure*(1.-5/800.))) a=time.time() - bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1.-5/800)))) + bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1.-5/800.)))) b=time.time() time.sleep(0.03*exposure) c=time.time() From e3510ca5637a61401eef0a1472b93376a83ce791 Mon Sep 17 00:00:00 2001 From: CCS Operator Account Date: Fri, 4 Sep 2020 13:39:50 -0700 Subject: [PATCH 5/5] fixed some error --- lib/bot_bench.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bot_bench.py b/lib/bot_bench.py index 70e2469..d6ea755 100755 --- a/lib/bot_bench.py +++ b/lib/bot_bench.py @@ -32,7 +32,7 @@ def setSpotFilter(filter): def openShutter(exposure): sanityCheck() print "Open shutter for %s seconds" % exposure - print "Actual open time to tell the shutter is %d seconds" % int(1000*exposure*(1.-5/800.))) + print "Actual open time to tell the shutter is %d mili seconds" % int(1000*exposure*(1.-5/800.)) a=time.time() bb.ProjectorShutter().exposure(Duration.ofMillis(int(1000*exposure*(1.-5/800.)))) b=time.time()