From 56c6dc1d0a8c083f4e689b00c5f81e880ef3092c Mon Sep 17 00:00:00 2001 From: Jonathan Sick Date: Thu, 12 Sep 2024 12:55:34 -0400 Subject: [PATCH] Increase default Times Square timeouts Make the defaults large enough to handle some of the heavier-weight Times Square notebooks like https://usdf-rsp-dev.slac.stanford.edu/times-square/github/lsst/schedview_notebooks/nightly/scheduler-nightsum that currently take 200 seconds to execute. On data-dev I've kept the shorter timeout for testing. --- applications/times-square/README.md | 4 ++-- applications/times-square/values-idfdev.yaml | 2 ++ applications/times-square/values.yaml | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/applications/times-square/README.md b/applications/times-square/README.md index e1c49b6ed0..7385571ed7 100644 --- a/applications/times-square/README.md +++ b/applications/times-square/README.md @@ -23,10 +23,10 @@ An API service for managing and rendering parameterized Jupyter notebooks. | cloudsql.instanceConnectionName | string | `""` | Instance connection name for a Cloud SQL PostgreSQL instance | | cloudsql.serviceAccount | string | `""` | The Google service account that has an IAM binding to the `times-square` Kubernetes service accounts and has the `cloudsql.client` role | | config.databaseUrl | string | None, must be set | URL for the PostgreSQL database | -| config.defaultExecutionTimeout | string | `"60"` | Default execution timeout for notebooks in seconds | +| config.defaultExecutionTimeout | string | `"300"` | Default execution timeout for notebooks in seconds | | config.enableGitHubApp | string | `"False"` | Toggle to enable the GitHub App functionality | | config.githubAppId | string | `""` | GitHub application ID | -| config.githubCheckRunTimeout | string | `"600"` | Timeout for GitHub check runs in seconds | +| config.githubCheckRunTimeout | string | `"900"` | Timeout for GitHub check runs in seconds | | config.githubOrgs | string | `"lsst,lsst-sqre,lsst-dm,lsst-ts,lsst-sitcom,lsst-pst"` | GitHub organizations that can sync repos to Times Square (comma-separated). | | config.logLevel | string | `"INFO"` | Logging level: "DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL" | | config.name | string | `"times-square"` | Name of the service. | diff --git a/applications/times-square/values-idfdev.yaml b/applications/times-square/values-idfdev.yaml index de7c4d6e60..9adb89ef9b 100644 --- a/applications/times-square/values-idfdev.yaml +++ b/applications/times-square/values-idfdev.yaml @@ -7,6 +7,8 @@ config: databaseUrl: "postgresql://times-square@localhost/times-square" githubAppId: "196798" enableGitHubApp: "True" + githubCheckRunTimeout: "600" # 10 minutes + defaultExecutionTimeout: "60" # 1 minute cloudsql: enabled: true instanceConnectionName: "science-platform-dev-7696:us-central1:science-platform-dev-e9e11de2" diff --git a/applications/times-square/values.yaml b/applications/times-square/values.yaml index 595bb9677b..1a26a01356 100644 --- a/applications/times-square/values.yaml +++ b/applications/times-square/values.yaml @@ -137,10 +137,10 @@ config: githubOrgs: "lsst,lsst-sqre,lsst-dm,lsst-ts,lsst-sitcom,lsst-pst" # -- Timeout for GitHub check runs in seconds - githubCheckRunTimeout: "600" # 10 minutes + githubCheckRunTimeout: "900" # 15 minutes # -- Default execution timeout for notebooks in seconds - defaultExecutionTimeout: "60" # 1 minute + defaultExecutionTimeout: "300" # 5 minutes worker: # -- Enable liveness checks for the arq queue