From 348d6324048c83b6093634a7128d13d425138771 Mon Sep 17 00:00:00 2001 From: Tiago Ribeiro Date: Mon, 30 Sep 2024 10:40:53 -0700 Subject: [PATCH 1/2] Update BaseMakeCalibrations.callpipetask to remove a call to ack.print_vars. This call is not really doing anything and the method is no longer available in kafka version of ts-salobj. --- python/lsst/ts/externalscripts/base_make_calibrations.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python/lsst/ts/externalscripts/base_make_calibrations.py b/python/lsst/ts/externalscripts/base_make_calibrations.py index f215ba493..5790494fd 100644 --- a/python/lsst/ts/externalscripts/base_make_calibrations.py +++ b/python/lsst/ts/externalscripts/base_make_calibrations.py @@ -774,7 +774,6 @@ async def call_pipetask(self, image_type): f"Received acknowledgement of ocps command for {image_type} pipetask." ) - ack.print_vars() job_id = json.loads(ack.result)["job_id"] # Wait for the command completion acknowledgement. @@ -783,7 +782,9 @@ async def call_pipetask(self, image_type): f"Received command completion acknowledgement from ocps for {image_type}." ) if ack.ack != salobj.SalRetCode.CMD_COMPLETE: - ack.print_vars() + self.log.debug( + f"OCPS job not complete, received {ack}. Continuing to wait for job result." + ) # Wait for the job result message that matches the job id we're # interested in ignoring any others (from other remotes). # This needs to follow the first acknowledgement From 63dcd9647ed3627cda595dfd2a398b7eedd7603d Mon Sep 17 00:00:00 2001 From: edennihy Date: Mon, 7 Oct 2024 11:59:17 -0300 Subject: [PATCH 2/2] Add news fragment. --- doc/news/DM-46458.feature.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/news/DM-46458.feature.rst diff --git a/doc/news/DM-46458.feature.rst b/doc/news/DM-46458.feature.rst new file mode 100644 index 000000000..fed0f2e32 --- /dev/null +++ b/doc/news/DM-46458.feature.rst @@ -0,0 +1 @@ +Update BaseMakeCalibrations.callpipetask to remove a call to ack.print_vars.