From a764225a302237181af9fad80585e79687a3348c Mon Sep 17 00:00:00 2001 From: Arun Kannawadi Date: Thu, 30 May 2024 12:32:29 -0400 Subject: [PATCH 1/3] Update CI pipeline to use MakeDirectWarp instead of MakeWarp. --- bin/pipeline.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/pipeline.sh b/bin/pipeline.sh index 84a7797..1a92c8d 100755 --- a/bin/pipeline.sh +++ b/bin/pipeline.sh @@ -61,7 +61,7 @@ pipetask --long-log --log-level="$loglevel" qgraph \ --input "$INPUTCOLL" --output "$COLLECTION" \ -p "$DRP_PIPE_DIR/pipelines/HSC/DRP-ci_hsc.yaml" \ -c calibrateImage:astrometry.maxMeanDistanceArcsec=0.20 \ - -c makeWarp:select.maxPsfTraceRadiusDelta=0.2 \ + -c makeDirectWarp:select.maxPsfTraceRadiusDelta=0.2 \ --save-qgraph "$QGRAPH_FILE" pipetask --long-log --log-level="$loglevel" run \ From 4d15b8e1938668c7e9cd116d49abbad0ee890964 Mon Sep 17 00:00:00 2001 From: Arun Kannawadi Date: Thu, 30 May 2024 17:46:56 -0400 Subject: [PATCH 2/3] Updates tests for existence of warps --- tests/test_validate_outputs.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/test_validate_outputs.py b/tests/test_validate_outputs.py index 365192b..f056c7f 100644 --- a/tests/test_validate_outputs.py +++ b/tests/test_validate_outputs.py @@ -202,11 +202,22 @@ def test_make_tables(self): self.check_pipetasks(["makeCcdVisitTable", "makeVisitTable"], 1, 1) self.check_datasets(["ccdVisitTable", "visitTable"], 1) + # TODO: Remove this test in DM-44612. def test_make_warp(self): """Test existence of warps.""" self.check_pipetasks(["makeWarp"], self._num_visits, self._num_visits) self.check_datasets(["deepCoadd_directWarp"], self._num_visits) + def test_make_direct_warp(self): + """Test existence of direct warps.""" + self.check_pipetasks(["makeDirectWarp"], self._num_visits, self._num_visits) + self.check_datasets(["deepCoadd_directWarp"], self._num_visits) + + def test_make_psfMatched_warp(self): + """Test existence of PSF-matched warps.""" + self.check_pipetasks(["makePsfMatchedWarp"], self._num_visits, self._num_visits) + self.check_datasets(["deepCoadd_psfMatchedWarp"], self._num_visits) + def test_assemble_coadd(self): """Test existence of coadds.""" From b3da147f6996df7255566015103a461867a0ff2b Mon Sep 17 00:00:00 2001 From: Arun Kannawadi Date: Tue, 30 Jul 2024 12:17:56 -0400 Subject: [PATCH 3/3] Remove test_make_warp --- tests/test_validate_outputs.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/test_validate_outputs.py b/tests/test_validate_outputs.py index f056c7f..c24254b 100644 --- a/tests/test_validate_outputs.py +++ b/tests/test_validate_outputs.py @@ -202,12 +202,6 @@ def test_make_tables(self): self.check_pipetasks(["makeCcdVisitTable", "makeVisitTable"], 1, 1) self.check_datasets(["ccdVisitTable", "visitTable"], 1) - # TODO: Remove this test in DM-44612. - def test_make_warp(self): - """Test existence of warps.""" - self.check_pipetasks(["makeWarp"], self._num_visits, self._num_visits) - self.check_datasets(["deepCoadd_directWarp"], self._num_visits) - def test_make_direct_warp(self): """Test existence of direct warps.""" self.check_pipetasks(["makeDirectWarp"], self._num_visits, self._num_visits)