Tests for Active Directory

ltb-project · Nov 19, 2024 · 27e54d0 · 27e54d0
1 parent 42f74e1
commit 27e54d0
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 1 deletion.
diff --git a/src/Ltb/Directory/ActiveDirectory.php b/src/Ltb/Directory/ActiveDirectory.php
@@ -339,7 +339,7 @@ public function isAccountValid($ldap, $dn) : bool {
             $entry = \Ltb\PhpLDAP::ldap_get_entries($ldap, $search);
         }
 
-        if (!$entry[0]['accountexpires']) {
+        if (!isset($entry[0]['accountexpires'])) {
             return true;
         }
 

diff --git a/tests/Ltb/DirectoryTest.php b/tests/Ltb/DirectoryTest.php
@@ -1059,4 +1059,65 @@ public function test_openldap_disable_account_ko(): void
         $this->assertFalse($disableAccountResult, "Should have encountered error while disabling OpenLDAP account");
     }
 
+    public function test_activedirectory_isvalid_nodate(): void
+    {
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 0,
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\ActiveDirectory)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
+    public function test_activedirectory_isvalid_enddate_before(): void
+    {
+        $dt = new DateTime;
+        $ad_date = ((int)$dt->modify("-1 week")->getTimestamp() + 11644473600) * 10000000;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'accountexpires' => [
+                        'count' => 1,
+                        0 => $ad_date,
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\ActiveDirectory)->isAccountValid(null, null);
+        $this->assertFalse($isAccountValid, "Account should not be valid");
+    }
+
+    public function test_activedirectory_isvalid_enddate_after(): void
+    {
+        $dt = new DateTime;
+        $ad_date = ((int)$dt->modify("+1 week")->getTimestamp() + 11644473600) * 10000000;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'accountexpires' => [
+                        'count' => 1,
+                        0 => $ad_date,
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\ActiveDirectory)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
 }