Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SAM 2.1 #78

Closed
iamnotagentleman opened this issue Oct 15, 2024 · 5 comments · Fixed by #82
Closed

Upgrade to SAM 2.1 #78

iamnotagentleman opened this issue Oct 15, 2024 · 5 comments · Fixed by #82
Labels
enhancement New feature or request

Comments

@iamnotagentleman
Copy link

Motivation & Examples

I have tested this locally, and it works as expected. The only challenge I encountered seems to be related to the configuration files—Hydra does not appear to detect version 2.1 files properly.

I'd be happy to volunteer to help prepare an update to address this issue.

@iamnotagentleman iamnotagentleman added the enhancement New feature or request label Oct 15, 2024
@luca-medeiros
Copy link
Owner

luca-medeiros commented Oct 15, 2024

Amazing. Didn't know about a 2.1.
Go ahead! guess just update the commit hash, readme, and the dict with the configs should do the trick. Don't think 2.0 support is needed.

@iamnotagentleman
Copy link
Author

Great. I am on it.

@arildgrimstveit
Copy link

Any progress on this? I am using SAM 2.1 for my project and it no longer works because it no longer finds the configs. I have not been able to figure out a fix yet.

@luca-medeiros luca-medeiros mentioned this issue Oct 17, 2024
5 tasks
@arildgrimstveit
Copy link

arildgrimstveit commented Oct 17, 2024

Apparently i had to use pip install without -e to import the packages into my environment and not use symbolic links.

@luca-medeiros
Copy link
Owner

mind trying #82?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants