Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is too good! #1

Closed
tmikaeld opened this issue Aug 10, 2022 · 4 comments
Closed

This is too good! #1

tmikaeld opened this issue Aug 10, 2022 · 4 comments

Comments

@tmikaeld
Copy link

Hello!

We started testing this in our environment and just wanted to say, what a breath of fresh air!

This thing has been flying and it's easy to use, has great documentation and superb performance.

Keep up the good work man 👍

@lucas-gaitzsch
Copy link
Owner

lucas-gaitzsch commented Aug 13, 2022

Thank you very much for your feedback. I am glad to hear that you enjoy this piece of software!
Let me know if you have some suggestions or find a bug.
Feel you free to contribute to this project. I have opened a new issue (#2) for feedback and feature proposals.

@tmikaeld
Copy link
Author

So far so good, it would be nice if input could be sanitized from XSS, but we already do that anyway.

@lucas-gaitzsch
Copy link
Owner

The input is sanitized, if you use a template engine.
If you use the /pdf/from/html/render method, JavaScript was executed. This is useful for some use cases like displaying a chart with a js charting lib (see Demo).

@tmikaeld
Copy link
Author

tmikaeld commented Sep 7, 2022

Great, I think the dev on the team didn't think about the template engines when he tested. I'll close this "issue" ;-)

@tmikaeld tmikaeld closed this as completed Sep 7, 2022
JoeAlisson referenced this issue in JoeAlisson/pdf-turtle Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants