-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly filter system messages #147
Comments
Hi @lucasrodes. I managed to overcome the issues for Desktop by reformatting the headers And I've also overcome the Community issue by simply finding the substring "added you to a group in the community" and removing that line completely:
But my latest issue is when the text is from a community & desktop. I will remove the following line: But the following function returns NoneType: If the text originates from mobile, and I remove the "added you to a group in the community" line, the Similarly if the text is converted from desktop to mobile, I am able to get it to work. But when it is a combination of both, it will fail. Anyway I am able to overcome it? |
I've found a temporary workaround: For desktop exports, there exists an additional username/phone number before the first message.
Works: Doesn't work: Temporary approach is to check if its a phone number, if so remove it. Very adhoc but this will temporarily solve my problem, but it may help you when fixing for community and desktop support. |
We are currently working on parsing system messages. However, there seems to be some particularities depending on the OS (Android, iOS), the device (mobile, desktop), etc.
Multiple environments
iOS
System messages are shown the same as the user names, but using the chat name as the user name
Android
System messages are sent without using the field allocated for "username".
See the example from #139:
Mobile vs desktop
Also, there are some differences between mobile vs. desktop, where the desktop seems to filter some system messages.
Communities
How the format in community chat history differs from groups' is unclear. We should explore this further (and potentially create a separate tracking issue for that).
Solutions
iOS/Android
We are almost finished with a solution supporting system messages for iOS devices:
We should investigate a similar solution for chats exported from Android devices.
mobile/desktop
My intuition here is to go with full mobile support and skip desktop support for now. We should signal this somewhere in the docs.
Communities
Same as in desktop, do not support this for now.
The text was updated successfully, but these errors were encountered: