Add bounded __namespace__ query support.

[danjacques]

This is a valid GQL query:
SELECT __key__ FROM __namespace__ WHERE __key__ > KEY(__namespace__, "foo")

Currently, bounded __namespace__ queries will not work. There are two underlying problems, one global and one specifically applying to impl/memory.

Globally, FinalizedQuery.Valid disallows special kind keys when validating inequality filters, so this query cannot be validated.

Additionally, in impl/memory, inequality filters aren't applied to namespace queries.

[riannucci]

Hm I thought I did start/end in impl/memory, but I guess not

On Sat, Apr 23, 2016, 17:02 Daniel Jacques [email protected] wrote:

This is a valid GQL query:
SELECT key FROM namespace WHERE key > KEY(namespace, "foo")

Currently, bounded namespace queries will not work. There are two
underlying problems, one global and one specifically applying to
impl/memory.

Globally, FinalizedQuery.Valid
https://github.com/luci/gae/blob/76382c0/service/datastore/finalized_query.go#L331
disallows special (...) kind keys when validating inequality filters,
so this query cannot be validated.

Additionally, in impl/memory, inequality filters aren't applied to
namespace queries.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#49