Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When pressing retry in new swarming UI you can't use back button #286

Open
mi-ac opened this issue Nov 28, 2016 · 1 comment
Open

When pressing retry in new swarming UI you can't use back button #286

mi-ac opened this issue Nov 28, 2016 · 1 comment

Comments

@mi-ac
Copy link
Contributor

mi-ac commented Nov 28, 2016

Actions:

  • Press retry on a swarming task.
  • Answer yes in dialog.
    -> Url changes to new task
  • Press back-button to go back to previous task
    -> Back-button is grayed out.
    Expectation:
    I'd expect to be able to get back to the last URL with the back button.
chromium-infra-bot pushed a commit that referenced this issue Nov 29, 2016
@kjlubick
Make retried tasks non-idempotent
9694fdb 
Also make the idempotent property visible on the UI (in more details).

Also on retry, push the state to window.history so the back button works
(kindof)

See #285 and
#286

BUG=

Review-Url: https://codereview.chromium.org/2537513003
@kjlubick
Copy link
Contributor

This partially works now. You can hit the back button, but you need to refresh to reload the right issue number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kjlubick @mi-ac and others