From 059c565b26430a18ff05ef9e9117a100bcdc431f Mon Sep 17 00:00:00 2001 From: Michael Plunkett <5885605+michplunkett@users.noreply.github.com> Date: Fri, 4 Oct 2024 12:15:53 -0500 Subject: [PATCH] Add donate link to footer (#1127) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Fixes issue https://github.com/lucyparsons/OpenOversight/issues/215 ## Description of Changes Added a `Donate` link to the footer so that it is available on all pages throughout the application instead of just the home page. I also updated the casing of `Download department data` so that it matches the rest of the casing on the footer. ## Screenshots (if appropriate) Before: Screenshot 2024-10-03 at 4 25 31 PM After: Screenshot 2024-10-03 at 4 26 08 PM ## Tests and Linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. --- OpenOversight/app/templates/base.html | 4 +++- OpenOversight/tests/routes/test_other.py | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/OpenOversight/app/templates/base.html b/OpenOversight/app/templates/base.html index 218e9a818..3da5cec19 100644 --- a/OpenOversight/app/templates/base.html +++ b/OpenOversight/app/templates/base.html @@ -150,7 +150,9 @@
OpenOversight

Lucy Parsons Labs
- Download department data + Donate +
+ Download Department Data

diff --git a/OpenOversight/tests/routes/test_other.py b/OpenOversight/tests/routes/test_other.py index 9e19ead5c..ce50cf9bd 100644 --- a/OpenOversight/tests/routes/test_other.py +++ b/OpenOversight/tests/routes/test_other.py @@ -27,6 +27,12 @@ def test_routes_ok(route, client, mockdata): rv = client.get(route) assert rv.status_code == HTTPStatus.OK + # Assert donate link is in all base pages + assert ( + 'Donate' + in rv.data.decode() + ) + def test_user_can_access_profile(client, session): with current_app.test_request_context():