Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for Django 4 support #81

Open
NiklasMerz opened this issue Oct 26, 2022 · 5 comments
Open

New release for Django 4 support #81

NiklasMerz opened this issue Oct 26, 2022 · 5 comments

Comments

@NiklasMerz
Copy link

I would kindly ask for a new pip release to support Django 4.x. With ugettext_lazy the current release does not work.

Thanks for this cool project.

@gabn88
Copy link

gabn88 commented Nov 9, 2022

The ugettext_lazy is fixed in the current master, however the is_ajax method also doesn't exist on request

@Moring
Copy link

Moring commented Jan 21, 2023

Added this to my build script for Django 4.x:

#!/bin/bash
PYTHON_SITE_PACKAGES=$(python -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/admin.py"
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/models.py"
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/mail.py"
sed -i "s/is_ajax()/META.get('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest'/g" "$PYTHON_SITE_PACKAGES/tellme/views.py"

@gabn88
Copy link

gabn88 commented Jan 23, 2023

Added this to my build script for Django 4.x:

#!/bin/bash
PYTHON_SITE_PACKAGES=$(python -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/admin.py"
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/models.py"
sed -i "s/ugettext_lazy/gettext_lazy/g" "$PYTHON_SITE_PACKAGES/tellme/mail.py"
sed -i "s/is_ajax()/META.get('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest'/g" "$PYTHON_SITE_PACKAGES/tellme/views.py"

I don't recommend to create a buildscript like this on a production site. Instead it is recommended to add a (custom) fork of django-tellme that includes the fix in requirements.txt. (something like git+https://github.com/xxx/xxx#egg=django-tellme)

@Moring
Copy link

Moring commented Jan 23, 2023

Valid. But good practice is to pin the version, and cover it with a test or two. So functionally, there should be no difference. Reasonable minds can disagree.

@agusmakmun
Copy link

Hello @ludrao, can I help you to update your package? Can you please invite me as a collabolator in this repository & pypi?
I have capability to upgrade your package to pypi as well, here is my user: https://pypi.org/user/agaust/

Because it seems outdated now, and you have many requests from people who are using your awesome package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants