fix: only use vim.iter if available to avoid accidental breaking change
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah that explains my issue that just started happening. Thanks for the fix! Please merge this one fast :) |
lukas-reineke
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.6.0's release had a breaking change when it changed what version of neovim it supported. This reverts the breaking change if using an older version of neovim but still uses the new, non-deprecated API if it's available. This is particularly important immediately after a release because package managers haven't all caught up to providing 0.10 and it may not be widely available or even used in stable environments until the first path release. I think if we don't want to merge this we should at least revert the v3.6.0 release and tag v4 to indicate the breaking nature of the release.
Thanks so much for all your effort supporting and developing this great plugin!