Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scope logic with unknown language #928

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: scope logic with unknown language #928

merged 1 commit into from
Oct 4, 2024

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Oct 4, 2024

If the language is not listed in the languages "officially" supported by ibl, scope[lang] is nil.

@guibou
fix: scope logic with unknown language
b40da52 
If the language is not listed in the languages "officially" supported by
ibl, `scope[lang]` is `nil`.
@guibou guibou mentioned this pull request Oct 4, 2024
Closed
@guibou
Copy link
Contributor Author

guibou commented Oct 4, 2024

This is related to #926 and recent #927

lukas-reineke
lukas-reineke approved these changes Oct 4, 2024
View reviewed changes
Copy link
Owner

@lukas-reineke lukas-reineke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lukas-reineke lukas-reineke merged commit 3af6493 into lukas-reineke:master Oct 4, 2024
7 of 8 checks passed
@guibou guibou deleted the fix_scope_detection_with_unknown_language branch October 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reineke lukas-reineke lukas-reineke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guibou @lukas-reineke