Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template renaming should not be exclusive to components #32

Closed
lukasjarosch opened this issue Oct 21, 2022 · 6 comments
Closed

Template renaming should not be exclusive to components #32

lukasjarosch opened this issue Oct 21, 2022 · 6 comments

Comments

@lukasjarosch
Copy link
Owner

Currently, the templater only allows renames for component rendering.
But it would be nice to be able to expose that functionality to the other template rendering methods Execute and ExecuteAll.

This would introduce just a small change and generalise the use of Skipper even more.

@alxndr13
Copy link
Collaborator

i'll work on this one, maybe i'll come up with something in the next hour or so

@alxndr13
Copy link
Collaborator

i'm not able to get the make example tests running, maybe i need some more infos the next few days :)

@lukasjarosch
Copy link
Owner Author

The secret example is currently the one whith which I am working and should be running. I'm not sure about the other examples.

@alxndr13
Copy link
Collaborator

Seems like the others do not work anymore.. i'll see what i can do :)

@alxndr13
Copy link
Collaborator

pushed a first draft into #34

@lukasjarosch
Copy link
Owner Author

lukasjarosch commented Oct 24, 2022

You rock 🚀, thanks for contributing in the first place.
I've added a few comments to the PR, I like it 😄.

I've also added a feature request #36 to work on the examples and make them more meaningful in the future.

lukasjarosch added a commit that referenced this issue Oct 25, 2022
#32: Template renaming should not be exclusive to components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants