Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identification for pomodoro or a break #15

Closed
lukaszbanasiak opened this issue Jan 22, 2015 · 15 comments
Closed

Identification for pomodoro or a break #15

lukaszbanasiak opened this issue Jan 22, 2015 · 15 comments
Milestone

Comments

@lukaszbanasiak
Copy link
Owner

lukaszbanasiak commented Jan 22, 2015

Ray Drew by email:

Sometimes I start the break and continue working (realise I shouldn't do this!) then I don't remember if I'm in a pomodoro or a break - is there some way to indicate which I'm in - maybe the tooltip could say [start break] [stop break] when in a break or the task bar icon could have a different colour progressing when in a break?

@tabrs
Copy link

tabrs commented Feb 10, 2015

This is exactly what I've wanted to post. When your app is on default settings (counting from 0 up) it is very hard to recognize if I'm on the rest period. It would be good to add the indicator which period is currently running.

@floatas
Copy link
Collaborator

floatas commented Feb 10, 2015

Now when mouse is over timer, on right top corner minimize and close buttons are shown we could add 'Work' or 'Break' to the left side, and when period ended 'Start break' or 'Start work' or something similar. Also task bar has 'Paused' state with yellow color which we can use for break period.

@tabrs
Copy link

tabrs commented Feb 11, 2015

I was playing a bit with it and the code and made a slight redesign - will do a fork and make a commit, so you can check and merge whatever you would like to. Will post here when it is done - need to do some refactoring and bugfixing first.

Pomodoro in progress:
image

Mouse over:
image

Period is over:
image

Period is over maximized:
image

@floatas
Copy link
Collaborator

floatas commented Feb 11, 2015

I see a small problem with this template, it is really wide and it wont be possible to put timer in corner. Whe you finish it, I will try to make setting to switch templates between old one and this. Then it wouldn't be hard to make templates as plugins.

@tabrs
Copy link

tabrs commented Feb 11, 2015

This template has been designed this way to have the possibility to lay over the window handle, which is the way I'm using it. I prefer to have the corner available for interactions. Anyway I'm not the only one and I see your point. It would be good to have the possibility to change the look according to a user's preference.

Unfortunatelly this template needed some deeper changes, but you'll see yourself. I'll push my version until saturday latest, possibly earlier. Will do my best to push it still today.

@floatas
Copy link
Collaborator

floatas commented Feb 11, 2015

There's no hurry, I myself will have more time only on weekend to review your changes

@tabrs
Copy link

tabrs commented Feb 15, 2015

Sorry for being late, but changes were more deeper than I thought. I was very likely rewritten half of the application (UI + logic).

Additionally I have been thinking about your requirement to have the possibility to pin this to a right corner and even I did not implemented this yet I've prepared the layout. Idea is to switch window buttons with clock when the user moves the window to right corner. Anyway still lot of work to do I think.

Now how it looks like now:

Minimized version:
image

Mouse over:
image

Pomodoro period started:
image

Pomodoro period started (including Quote source):
image

Paused session:
image

Check it on https://github.com/tkorcak/YAPA/tree/master/YAPA

@floatas
Copy link
Collaborator

floatas commented Feb 16, 2015

Or just add option to switch timer location between left and right. New design looks really cool 👍
I tried to refactor application to separate view from application logic, still a lot of work left, not sure when will have time to continue. You can try to merge and continue my work, if you have time, main idea is to create helper classes and inject them, so other views can be made without duplicate code.
https://github.com/floatas/YAPA/tree/plugins

@tabrs
Copy link

tabrs commented Feb 22, 2015

Guys, I'm pretty ill now, so I'm getting some rest. Hope I'll be fit next week so I can do some adjustments to this, but feel free to examine or contribute yourselves. See ya.

@floatas
Copy link
Collaborator

floatas commented Feb 25, 2015

We went a bit too far from main issue, I created separate task to discuss about custom themes #21

@tabrs
Copy link

tabrs commented Feb 28, 2015

Hi, just to add - in case you will do the merge and start the base on my changes then you can consider this ticket as solved/closed.

@floatas floatas added this to the 2.0.0 milestone Sep 23, 2016
@fghber
Copy link
Contributor

fghber commented Mar 18, 2017

Wow, I love your new counter theme with all improved UI and the quotes @tkorc Chapeau!
I would really like to see this adapted in the main branch.

fghber added a commit to fghber/YAPA that referenced this issue Mar 20, 2017
@floatas
Copy link
Collaborator

floatas commented Mar 20, 2017

I don't believe we will change default YAPA theme, maybe with some small adjustments. I'm working on YAPA 2.0 (almost finished) and it will support custom themes, I will port this theme to it, hopefully @tkorc won't mind.

@tabrs
Copy link

tabrs commented Mar 20, 2017

Hey @floatas, I won't mind at all :-) feel free...
Thank you @fghber anyway! Great it can make someone else's life more joyful :-) 👍

@fghber fghber mentioned this issue Mar 20, 2017
@floatas
Copy link
Collaborator

floatas commented Mar 27, 2017

Fixed by adding icons, same as tkorc theme.

@floatas floatas closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants