Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing in handler terminates node process #115

Closed
pke opened this issue Nov 8, 2019 · 1 comment
Closed

Throwing in handler terminates node process #115

pke opened this issue Nov 8, 2019 · 1 comment

Comments

@pke
Copy link

pke commented Nov 8, 2019

Coming from koa I wonder how to protect polka from crashing the node process in case of an uncaught exception/promise rejection in one of the middlewares/handlers?
Shouldn't that just result in a 500 error but not an exit of the node process?

@lukeed
Copy link
Owner

lukeed commented Nov 8, 2019

This is a duplicate of #12. The TLDR is that:

A) this is fixed in the @next release and will be doable in 1.0
B) this is my recommendation for current 0.x/stable release: #12 (comment)

Hope that helps!

@lukeed lukeed closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants