This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Emoji Picker feature #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that when you refresh it shows all of the notifications again. It also needs some touch up work around the requesting user permission flow for the notifications.
…use this code already completed the notification feature and mine was just half complete and therefore no longer needed.
… changed the anchor tag to a button because I forgot to change it back when I was debugging.
|
Hey there are some updates we could add to this to make it better and if I have the time I definitely will, but right now if you put an emoji in the text input by itself it is still very small instead of having it get bigger like you see with slack. However, I have been pretty busy as I am just moving so @lukejacksonn or if anyone else wants to make those improvements that be cool. |
ahmadao2214
reviewed
Jan 8, 2019
| }) | ||
| } | ||
|
|
||
| updateCursorPostion(e) { |
There was a problem hiding this comment.
Looks like this name is missing the letter i
Should be updateCursorPosition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.