Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in navigating past an indentation scope in IND/RAW mode #22

Open
lukstafi opened this issue Apr 13, 2023 · 0 comments
Open

Bugs in navigating past an indentation scope in IND/RAW mode #22

lukstafi opened this issue Apr 13, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lukstafi
Copy link
Owner

Below, ctrl+alt+l for both the first source and the second source @ position gives the first target ^ position. It would be most convenient if both gave the second target ^ position. Logical consistency may push the second @ to stick with the current behavior of going to the first ^ since the position might be considered as inside the scope -- but in that case ctrl+alt+k should go to the second ^ instead of to the end of the outer scope, as it does currently. The first source @ should definitely go to the second ^ rather than the first ^.

  | Broadcast @(Dynamic_index {over_kind; from_left; other_axes_pointwise}, sh1, sh2) ->
    let subs = List.last_exn (list_of_dims sh2.output) in
    let output = map_dims sh2.output ~f:List.drop_last_exn in
    @let subs, output = match sh2.output with
      | Given []^ | Fixed [] -> assert false
      | Unknown | Inferred [] -> 1, Inferred []
      | Inferred dims ->
        let last, dims = List.last_exn dims, List.drop_last_exn dims in
        last, Inferred dims
      | Given dims ->
        let last, dims = List.last_exn dims, List.drop_last_exn dims in
        last, Given dims
      | Fixed dims ->
        let last, dims = List.last_exn dims, List.drop_last_exn dims in
        last, Fixed dims in
    ^let reduced_sh2 = {sh2 with output} in

So overall, two buggy behaviors: ctrl+alt+l and the first @; and either ctrl+alt+k or ctrl+alt+l, and the second @.

@lukstafi lukstafi added the bug Something isn't working label Apr 13, 2023
@lukstafi lukstafi self-assigned this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant