Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster drop of steps #1126

Open
arthurpaulino opened this issue Feb 14, 2024 · 0 comments
Open

Faster drop of steps #1126

arthurpaulino opened this issue Feb 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@arthurpaulino
Copy link
Contributor

In the implementation of prove_recursively for our Nova and SuperNova proofs, we take ownership of a vector of multiframes steps: Vec<C1LEM<'a, F, C>>. It's consumed and then dropped.

Here, it seems that we should be able to use the following trick: https://abrams.cc/rust-dropping-things-in-another-thread (thanks @huitseeker for the tip)

Note: we actually have two logical branches. In one branch, steps is consumed to instantiate cc. Meaning that on that branch specifically, cc is the thing we'd drop on a separate thread.

@arthurpaulino arthurpaulino added the enhancement New feature or request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant