Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sha256 coprocessor out of lurk crate #1178

Open
porcuquine opened this issue Feb 27, 2024 · 1 comment
Open

move sha256 coprocessor out of lurk crate #1178

porcuquine opened this issue Feb 27, 2024 · 1 comment

Comments

@porcuquine
Copy link
Contributor

The sha256 coprocessor does not belong in the Lurk crate. I think it was moved there as part of an attempt to increase code sharing in examples and benches that use it. It would be better to solve the problem through some other technique.

If Lurk had some need for a truncated sha256 operation, or was highly opinionated about wanting to provide this to others, then maybe it would make sense. As it stands, we're forced to concern ourselves with whether that coprocessor is correct, or what it would even mean for it to be correct. It's not that these are entirely uninteresting questions, but they cost more than they are worth. If this code did not live in the Lurk crate, it would be easier for us to formally declare our appropriate apathy.

@arthurpaulino
Copy link
Contributor

More context: #732 did this because the sha256 coprocessor code was replicated in three different places (benchmark + ivc example + nivc example). Now that it's centralized, it's easier for us to move it elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants