You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure about the correct way to fix this, so I'm looking for inputs.
How to reproduce
This bug has been found while leveraging the Bn256EngineKZG engine at PublicParams::setup both for Nova & Supernova. You can reproduce it on your machine by running this test on ethereum-lc/aggpk
I was also able to reproduce it on the aptos-lc if patching both belpepper & bellpepper-core to dev.
The text was updated successfully, but these errors were encountered:
Issue
The recent PR #88 introduces a new behavior for
Num::add
, favouringNone
toSome(v)
as a result in(Some(v), None) | (None, Some(v)
cases.This new behavior seems to break the current implementation of
PoseidonROCircuit::squeeze
inarecibo
. In this method we actually call theSpongeCircuit::absorb
method with the current state elements, that do not have any values at that stage.In
neptune
absorb
will calladd_rate_element
with aNum::add
that results on aNone
variant, transmitted to theset_element
method that leverages anunwrap
on the value and thus panicking.I'm not sure about the correct way to fix this, so I'm looking for inputs.
How to reproduce
This bug has been found while leveraging the
Bn256EngineKZG
engine atPublicParams::setup
both for Nova & Supernova. You can reproduce it on your machine by running this test on ethereum-lc/aggpkI was also able to reproduce it on the
aptos-lc
if patching bothbelpepper
&bellpepper-core
todev
.The text was updated successfully, but these errors were encountered: