Add an AllocatedNum addition constraint #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Oct 20, 2023
| @@ -539,6 +571,21 @@ mod test { | |||
| assert!(cs.get("num") == Fr::ONE); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_num_addition() { | |||
There was a problem hiding this comment.
It would be great to see some negative testing here.
Another useful tool would be to exemplify the modular nature of the addition, e.g. by using something close to the field modulus as one of the operands.
There was a problem hiding this comment.
I have updated the test.
varunthakore
commented
Oct 21, 2023
Comment on lines
+588
to
+592
| assert!(cs.is_satisfied()); | ||
| assert!(cs.get("sum num") == Fr::ZERO); | ||
| assert!(c.value.unwrap() == Fr::ZERO); | ||
| cs.set("sum num", Fr::ONE); | ||
| assert!(!cs.is_satisfied()); |
There was a problem hiding this comment.
@huitseeker By negative testing, do you mean to add tests such that the constraint system is not satisfied ? I am checking for this on lines 591-592.
huitseeker
approved these changes
Oct 22, 2023
This was referenced Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is corresponding to issue #33 created by @huitseeker. Added AllocatedNum addition constraint and corresponding test.