-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.1 -> 0.1.2 is a breaking change #17
Comments
I want to mirror my appreciation for your work on strip-ansi-escapes! Thank you. FWIW, this breaks the compilation of The suggestion above from @yannham is absolutely correct and I appreciate your swift action on this @luser, thanks! |
FWIW, this also breaks compilation of everything that depends on the |
Release |
As mentioned in luser#17, luser#11 among other things changed the public API in a way that causes failures to build. Thus those changes should be released under the `0.2.0` version to not break existing or new projects that don't lock the version to `0.1.1`. To close luser#17, and stop churn for the ecosystem `0.1.2` would need to be yanked as well.
Sorry about that! I did not do the due diligence here. I just yanked 0.1.2, I'll merge #18 and publish 0.2.0 to get things back on track. |
i thought rust semver said you can do anything before 1.0, why the yank and update from luser/strip-ansi-escapes#17
Thanks for the quick fix, this is very much appreciated! |
This reverts commit 15a80f1.
Hi, and first thanks for the work on strip-ansi-escapes! We use it as a dependency of the Nickel programming language. However, the recent update from 0.1.1 to 0.1.2 broke our build in some situations. Indeed, this update changed the interface of the public method
strip
(which doesn't return aResult<_, _>
anymore, but just aVec<u8>
).Changing the interface of a public method is a breaking change, and mandates an update to 0.2.0, as per semantic versioning. I would advise to yank the 0.1.2 version and to release a 0.2.0 version with the same content as 0.1.2.
The text was updated successfully, but these errors were encountered: