Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using system's esbuild if it is available #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eaon
Copy link

@eaon eaon commented Jan 23, 2025

Hi there,

I'm not entirely sure that this is functionality that you would even want, but I'm exploring Gleam and Lustre, and thought I'd experiment.

If you'd prefer to default to the build/.lustre/bin/esbuild binary (if it exists) I'd be happy to make the appropriate changes.

Closes #84

eaon added 2 commits January 23, 2025 18:44
esbuild will still be downloaded opportunistically or if specifically
instructed by using the add subcommand.
@hayleigh-dot-dev
Copy link
Contributor

Hey @eaon sorry this fell by the wayside ^.^

If you'd prefer to default to the build/.lustre/bin/esbuild binary (if it exists) I'd be happy to make the appropriate changes.

I think we could expose this as a flag for build / start, something like --use-system-esbuild so that this behaviour is opt-in. What do you think?

@eaon
Copy link
Author

eaon commented Feb 17, 2025

No worries, and sounds good, I can get on that! I've been thinking of doing the same for tailwind, so there may be an opportunity to have a --use-system-binaries that captures both/all binaries that the dev tools depend on - would you be open to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support user-supplied esbuild binary
2 participants