Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete container support #118

Closed
xortim opened this issue Feb 24, 2024 · 4 comments
Closed

complete container support #118

xortim opened this issue Feb 24, 2024 · 4 comments

Comments

@xortim
Copy link
Contributor

xortim commented Feb 24, 2024

This looks like a really promising library, thank you for sharing it.

Looking over the PVE API and the functionality implemented in the library. I was thinking the following enhancements would be helpful:

  • Implement node.NewContainer()
  • Add ContainerConfig struct
  • Add ContainerConfig field to Container struct
  • Update node.Container() to include container.Config

This shouldn't break the existing API and bring it in line with existing VirtualMachine behavior. It would also complete CRUD functionality for PVE containers.

@luthermonson
Copy link
Owner

I spent most of my time in the qemu endpoints that I barely touched the lxc stuff, I did abstract "qemu" to "VirtualMachine" and i dont see why "lxc" shouldn't be "Container" so let's go for it!

@xortim
Copy link
Contributor Author

xortim commented Feb 25, 2024

I'm (slowly) working on a PR for this. It might take a while as I'm a bit rusty with Go.

@luthermonson
Copy link
Owner

i tried to abstract the complexities so most get/put/post/delete aren't much more than a couple lines. you'll do fine and we can fix anything after you put up a PR

@luthermonson
Copy link
Owner

@xortim i think someone beat you to it #126, closing this for now but feel free to open new ones if anything was missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants