-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete container support #118
Comments
I spent most of my time in the qemu endpoints that I barely touched the lxc stuff, I did abstract "qemu" to "VirtualMachine" and i dont see why "lxc" shouldn't be "Container" so let's go for it! |
I'm (slowly) working on a PR for this. It might take a while as I'm a bit rusty with Go. |
i tried to abstract the complexities so most get/put/post/delete aren't much more than a couple lines. you'll do fine and we can fix anything after you put up a PR |
This looks like a really promising library, thank you for sharing it.
Looking over the PVE API and the functionality implemented in the library. I was thinking the following enhancements would be helpful:
node.NewContainer()
POST
to/nodes/{node}/lxc
node.Container()
to includecontainer.Config
This shouldn't break the existing API and bring it in line with existing VirtualMachine behavior. It would also complete CRUD functionality for PVE containers.
The text was updated successfully, but these errors were encountered: