-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing hostname to ssl handle #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. My only suggestion is to have .isServer
for the boolean flag instead of just .server
. It confused me for a bit thinking it held some table or uv struct.
It was originally |
I implemented this fix thinking that I was not touching any part of the public API; however, it seems that this PR would make secure-socket incompatible with older versions of coro-net. In other words, you would need to update to the latest coro-net to use the latest secure-socket. We'll have to carefully select version numbers this time, or I can adjust the fix to something non-breaking; something more like that which is proposed in #212. |
We should probably just bump the major version on coro-net and secure-socket to be safe. Looks good! |
I'm also fine with the suggestion in #212, it's a less invasive change and should work as well right? |
As discussed in IRC, I've restored backwards compatibility. Note that |
#212
luvit/luvit#986
luvit/luvit#987