Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value is always parsed as json which breaks exports #5

Open
Fardenz opened this issue Jul 25, 2022 · 0 comments
Open

Return value is always parsed as json which breaks exports #5

Fardenz opened this issue Jul 25, 2022 · 0 comments

Comments

@Fardenz
Copy link

Fardenz commented Jul 25, 2022

All requests are parsed assuming the response is going to be always JSON type, not taking into account the exceptions in the special endpoints. One of them is the export endpoint, which can return binary responses (png, pdf...) causing the return value to be null.

https://github.com/cumulio/cumul.io-sdk-php/blob/cabb8bda4bdb4f9f308f8bf755439c8211644e16/Cumulio.php#L97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fardenz