Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddingMatrix is never passed when building model #5

Open
airkid opened this issue Feb 23, 2019 · 3 comments
Open

embeddingMatrix is never passed when building model #5

airkid opened this issue Feb 23, 2019 · 3 comments

Comments

@airkid
Copy link

airkid commented Feb 23, 2019

When building model, it seems that the loaded glove embedding is not used.
I think thats one of the reason that I can't reproduct the experiment result.
https://github.com/lx865712528/JMEE/blob/494451d5852ba724d273ee6f97602c60a5517446/enet/models/ee.py#L20
https://github.com/lx865712528/JMEE/blob/494451d5852ba724d273ee6f97602c60a5517446/enet/run/ee/runner.py#L55

@mikelkl
Copy link

mikelkl commented Mar 7, 2019

Hi @airkid, I noticed the same problem, so I write code below to pass pretrained word embedding:

def load_model(self, fine_tune, embeddingMatrix=None):
    if fine_tune is None:
        return EDModel(self.a.hps, self.get_device(), embeddingMatrix=embeddingMatrix)

@mikelkl
Copy link

mikelkl commented Mar 7, 2019

Hi @ycc1028, the paperr mentions that pre-trained Glove word embedding is used

@airkid
Copy link
Author

airkid commented Mar 7, 2019

Hi @ycc1028 , after this modification it still can not reach the performance cause there are still another evaluate problem #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants