-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxqt-config-brightness: Set minimum backlight #858
base: master
Are you sure you want to change the base?
Conversation
<item> | ||
<widget class="QGroupBox" name="groupBox_3"> | ||
<property name="toolTip"> | ||
<string>The minimum value for backlight value can be really brightness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence needs to be corrected. Did you mean, "The minimum value of backlight can be too high"?
<property name="toolTip"> | ||
<string>The minimum value for backlight value can be really brightness. | ||
It is possible set this minimum value. | ||
Warning: If a very low backlight is set, a black screen can be shown.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, the first sentence isn't needed, and this tooltip can be changed to something like:
The minimum value of backlight.
Warning: A very low value can result in a black screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Fixed.
|
||
ui->backlightSlider->setMaximum(maxBacklight); | ||
ui->backlightSlider->setMinimum(minBacklight); | ||
ui->backlightSlider->setValue(value); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newline is missing here.
IMHO, the code needs to take care of the minimum value automatically. The new GUI seems too confusing to me. Do other DEs do this? |
Do other DEs do this? No. Other DEs doesn't set a minimum value for the backlight. For example, I have downloaded the code of XFCE and I have checked the minimum value for the backlight and it is set to 0. Thanks for your hard work. |
Good idea. |
In some hardware the 5% as minimum value of backlight can be too brightness. Advanced options has been added to select this minimum value: