Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Color #9

Open
lucaorio opened this issue Jan 9, 2019 · 13 comments
Open

Lock Color #9

lucaorio opened this issue Jan 9, 2019 · 13 comments

Comments

@lucaorio
Copy link

lucaorio commented Jan 9, 2019

Is there a chance to see the Lock Color feature part of Colorbox added here too, eventually? :)

@k-vyn
Copy link
Contributor

k-vyn commented Jan 10, 2019

Yep! Working on updating the algorithm and adding proper documentation.

@porada
Copy link

porada commented May 27, 2019

@k-vyn, is there any ETA on that?

@methyl
Copy link

methyl commented Sep 30, 2019

@k-vyn I'd love to port https://www.colorbox.io/ directly as a Figma plugin and it will be great to have color locking possibility.

@macintoshhelper
Copy link

Hi, I've reverse engineered the color lock and minor steps feature from ColorBox, I just want to check that it's ok to publish it to my fork of this project? (licensed under the original license of-course) @k-vyn

If so, let me know please, and I can add some docs, tests and examples, and open a PR to merge back to this repo 🙂.

@nahiyankhan
Copy link

@macintoshhelper Would love to check your additions! Do you have it public? 🙏

@macintoshhelper
Copy link

@macintoshhelper Would love to check your additions! Do you have it public? 🙏

No, sorry, would need permission to use or publish it. I have an open PR with an ES6 refactor though: #13

@porada
Copy link

porada commented May 27, 2020

Since this repository is open source, I don’t think you need explicit permission to publish a fork.

@nahiyankhan
Copy link

@macintoshhelper Understandable if thats the case! To @porada's point it seems like no permission is needed?

@macintoshhelper
Copy link

macintoshhelper commented May 28, 2020

Since this repository is open source, I don’t think you need explicit permission to publish a fork.

Reverse engineered (decompiled code) does require explicit permission to use or publish.

I've already published a fork (ES6 + Rollup bundling): https://github.com/elemental-design/coloralgorithm/tree/feat/rollup-build – if there's interest, I can open it up for external contribution. I've been meaning to work on adding bezier curve interpolation (for multiple colour locks) for a while.

While it's not equivalent to color lock, I developed a library that automates hue ranges for you based on hex values (based on top of lyft/coloralgorithm): https://github.com/elemental-design/colors/blob/master/src/index.js .

@k-vyn
Copy link
Contributor

k-vyn commented Jun 10, 2020

@macintoshhelper @nahiyankhan

Sorry for the long delay, I no longer work at Lyft, so I'm not sure who will take over the responsibility of this repo. This may become inactive.

In any case, for context Lock hex feature was functionality that was built into ColorBox after many people requested it, and it was never re-added into the original Color Algorithm.

I forked this repo, and I did a big revamp of the algorithm and provided a lot more functionality than the original one. Also, I hope it'll be a little easier to understand/develop with.

Check it out here - https://github.com/k-vyn/coloralgorithm

@macintoshhelper
Copy link

@macintoshhelper @nahiyankhan

Sorry for the long delay, I no longer work at Lyft, so I'm not sure who will take over the responsibility of this repo. This may become inactive.

No problem, thanks a lot for your reply and fork! 🙂 Would be great to have some place for community contribution to the project, I'd be happy to maintain a fork.

@nahiyankhan
Copy link

@macintoshhelper @nahiyankhan

Sorry for the long delay, I no longer work at Lyft, so I'm not sure who will take over the responsibility of this repo. This may become inactive.

In any case, for context Lock hex feature was functionality that was built into ColorBox after many people requested it, and it was never re-added into the original Color Algorithm.

I forked this repo, and I did a big revamp of the algorithm and provided a lot more functionality than the original one. Also, I hope it'll be a little easier to understand/develop with.

Check it out here - https://github.com/k-vyn/coloralgorithm

No worries! You did an amazing work with this and it has helped me a lot! I was able to add in the lock functionality too actually. I agree with @macintoshhelper Would love to contribute.

Good luck with your next venture!

@k-vyn
Copy link
Contributor

k-vyn commented Jun 11, 2020

Totally! I agree. I'm planning on maintaining that fork going forward, and I'd love contributions on that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants