parse: Don't use assembly code as data #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samueldr ... can you add a branch including your fixes to your fork? |
Sure, Still unsure (needs other eyes on it) about the optimizations commit at the tip, so check with it reverted if you see differences in behaviour with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Hi! 👋
Not sure the solution is correct, but it works.
I'm not sure if the
textsection should fold down repeated uses of e.g. the same string in the code to a single instance. Currently it does not, but if it does, it would be necessary to ensure that someasm(...)string that coincides with an arbitrary string elsewhere does not get elided accidentally.Feel free to suggest changes, though provide good hints :).