Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolve option for custom modal #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cgoessen
Copy link

I've added 'resolve' as the last param and kept data for legacy support.
My use case is to use the same controller for full page and modal, which requires to have a few promises resolved in both.

  • remove as not needed after a modalInstance dismiss

@niemyjski
Copy link
Collaborator

@cgoessen Can you please resolve the merge conflicts.
@m-e-conroy can you take a look at this.

@cgoessen
Copy link
Author

hi,
I rebased my branch from the new upstream but I can't test it at the moment:
https://github.com/cgoessen/angular-dialog-service/tree/rebase-upstream

I'll update my pull request when I know it works.

@niemyjski
Copy link
Collaborator

Thank you

@niemyjski
Copy link
Collaborator

Looks like there still are some conflicts

@niemyjski
Copy link
Collaborator

Can you please resolve any conflicts so we can review and get this merged in.

@cgoessen
Copy link
Author

I'll see what I can do.

I don't have the project on which I was working on at that time.

@niemyjski
Copy link
Collaborator

Guess we can close this then or merge it in if the conflicts are resolved? Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants