Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single status line for one stream #43

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jan 17, 2024

This change makes status lines conditional on the number of streams. Previously, single stream results would report two identical results. This is a little confusing, since the results for single streams are identical. This change reports a single summary for single stream and multiple summaries for multi stream tests.


This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7558773813

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 70.136%

Totals Coverage Status
Change from base Build 7558604334: -0.08%
Covered Lines: 876
Relevant Lines: 1249

💛 - Coveralls

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 8ce8851 into main Jan 17, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-single-status branch January 17, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants