Skip to content

Commit

Permalink
Use a custom image location for stackdriver_exporter (#944)
Browse files Browse the repository at this point in the history
* Uses temp custom image for stackdriver_exporter

#896

This commit updates the stackdriver_exporter image path to a temporary
location in the measurementlab Docker hub org. Once a new version of
stackdriver_exporter is released, we should revert the image path to the
official one.

* Uses temp image location for mlabns-stackdriver_exporter

#896

This commit updates the mlabns-stackdriver_exporter image path to a
temporary location in the measurementlab Docker hub org. Once a new
version of stackdriver_exporter is released, we should revert the image
path to the official one.
  • Loading branch information
nkinkade authored Aug 22, 2022
1 parent eaa7aec commit 94c52d8
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
13 changes: 12 additions & 1 deletion k8s/prometheus-federation/deployments/mlabns-stackdriver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,18 @@ spec:
prometheus-node: 'true'
containers:
- name: stackdriver
image: prometheuscommunity/stackdriver-exporter:v0.11.0
# NOTE: we are using a custom built image to incorporate a bug fix
# that, as of writing this note (2022-08-22), has not yet been included
# in a release. Once a new release of stackdriver_exporter has been
# made that includes the fix, we should revert the image path back to
# the official one. More details:
#
# https://github.com/prometheus-community/stackdriver_exporter/issues/85
# https://github.com/prometheus-community/stackdriver_exporter/pull/153
# https://github.com/m-lab/prometheus-support/issues/896
#
# image: prometheuscommunity/stackdriver-exporter:<version>
image: measurementlab/stackdriver_exporter:v0.12.0-mlab
args: [
# Metrics are available with some delay, so look 5 minutes in the past.
"--monitoring.metrics-offset=5m",
Expand Down
13 changes: 12 additions & 1 deletion k8s/prometheus-federation/deployments/stackdriver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,18 @@ spec:
prometheus-node: 'true'
containers:
- name: stackdriver
image: prometheuscommunity/stackdriver-exporter:v0.11.0
# NOTE: we are using a custom built image to incorporate a bug fix
# that, as of writing this note (2022-08-22), has not yet been included
# in a release. Once a new release of stackdriver_exporter has been
# made that includes the fix, we should revert the image path back to
# the official one. More details:
#
# https://github.com/prometheus-community/stackdriver_exporter/issues/85
# https://github.com/prometheus-community/stackdriver_exporter/pull/153
# https://github.com/m-lab/prometheus-support/issues/896
#
# image: prometheuscommunity/stackdriver-exporter:<version>
image: measurementlab/stackdriver_exporter:v0.12.0-mlab
args: [
# Metrics are available with some delay, so look 5 minutes in the past.
"--monitoring.metrics-offset=5m",
Expand Down

0 comments on commit 94c52d8

Please sign in to comment.