Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating GcPtr's internal pointer (get rid of offsetof and use RTTI + pointer to a member?) #84

Open
m4drat opened this issue Mar 14, 2023 · 2 comments
Open

Fix updating GcPtr's internal pointer (get rid of offsetof and use RTTI + pointer to a member?) #84

m4drat opened this issue Mar 14, 2023 · 2 comments
Assignees
@m4drat
Labels
Medium Refactoring

Comments

@m4drat
Copy link
Owner

m4drat commented Mar 14, 2023 •
edited
Loading

This might require rewriting GcPtr base class to contain pointer to an object?
@m4drat m4drat self-assigned this Mar 14, 2023
@m4drat
Copy link
Owner Author

m4drat commented Mar 14, 2023

https://stackoverflow.com/questions/7464068/base-class-fields-offset

@m4drat
Copy link
Owner Author

m4drat commented Nov 21, 2023

Even better - move pointer to an object inside GcPtr base class. Make UpdatePtr and GetVoid non-virtual. In the GC loop simply cast to GcPtr and call UpdatePtr on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4drat m4drat

Labels
Medium Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m4drat