Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the buffer module #57

Open
m4rw3r opened this issue Sep 22, 2016 · 0 comments
Open

Improving the buffer module #57

m4rw3r opened this issue Sep 22, 2016 · 0 comments
Milestone

Comments

@m4rw3r
Copy link
Owner

m4rw3r commented Sep 22, 2016

Rename module to stream, since it provides tools to deal with streaming data, not just buffering.

Renames

  • stream::Source <- data_source::DataSource
  • stream::IteratorSource <- data_source::IteratorDataSource
  • stream::ReadSource <- data_source::ReadDataSource
  • stream::FixedSizeBuffer
  • stream::GrowingBuffer
  • stream::BufferedInput <- InputBuf
  • stream::Slice <- SliceStream
  • stream::BufferedSource <- Source
  • stream::Error <- StreamError
  • stream::Buffer
  • stream::Stream

Fixes/Updates

  • Source::read should either be unsafe or should always be provided with zeroed memory.
  • Error only use Retry where the stream itself will attempt to refill before trying the parser again, and Incomplete should be used otherwise if the parser requires more data.
  • Look at how Tokio manages buffers and see if we can get that to mesh with Chomp
@m4rw3r m4rw3r added this to the Version 1.0.0 milestone Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant