-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story mode map detachment on mobile #440
Comments
Believe it's this one from the Problem Report: https://portal.mwater.co/#/dashboards/a943e66c43c0404b9bd397aacf388918 |
There is no map widgets in that dashboard |
May have been removed if it wasn't working. I'll ask Brian directly. |
Brian says:
Can you replicate with that info on any dashboard with a map? |
Cant replicate on iPhone X chrome |
Finally reproduced. @grassick you added this line here did that fix the jitter? It appears this line introduced map tile detachment in ios |
I'm not sure whether it did fix the jitter in the end! I'd try lots of resizing before removing it in production. |
The resize listener we are using currently injects a div and some style, which I think is the source to the jitter too? Here is a hook implementing that Would it be worth refactoring, on the long run? |
It doesn't support Safari, but the polyfill is good? I love hooks, but a global refactor is pretty big. Maybe AutoSizeComponent could use hooks and this internally? |
Brian reports:
The text was updated successfully, but these errors were encountered: