Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme colors not working in Ansi256 #26

Open
jphager2 opened this issue Nov 6, 2023 · 0 comments
Open

Theme colors not working in Ansi256 #26

jphager2 opened this issue Nov 6, 2023 · 0 comments

Comments

@jphager2
Copy link
Contributor

jphager2 commented Nov 6, 2023

Describe the bug
Text colors do not work as intended in Ansi256

To Reproduce
Steps to reproduce the behavior:

  1. Use Ansi256 Terminal (e.g. Mac terminal with Settings > Profile > Advanced > Declare terminal as: xterm-256color
  2. Configure colors in ~/.typer.yaml like:
theme:
  bar:
    color: '#555555'
  graph:
    color: purple
    height: 3
  text:
    error:
      foreground: '#FF00000'
      background: '#FFFFFF'
    typed:
      foreground: '#0000FF'
    untyped:
      foreground: '#555555'
  1. run typer

Expected behavior
The configured colors should be approximated for the terminal.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
I think that the termenv color profile should be used when setting the colors. Will make a PR for this. (Also termenv has had several version changes, and could be updated. Happy to do that if desired.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant