From 3597125d626bc635d6f7efc1bc429ebf43f8ede0 Mon Sep 17 00:00:00 2001 From: John Omotani Date: Wed, 22 Nov 2023 19:54:49 +0000 Subject: [PATCH 1/3] Fix use of makie_post_processing with NetCDF output files A test for whether files actually exist assumed that output files ended in `.h5`, which meant that NetCDF output files (with a `.cdf` suffix) could not be read. --- src/makie_post_processing.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/makie_post_processing.jl b/src/makie_post_processing.jl index 212827dea..00e15f11e 100644 --- a/src/makie_post_processing.jl +++ b/src/makie_post_processing.jl @@ -840,7 +840,8 @@ function get_run_info(run_dir::Union{AbstractString,Tuple{AbstractString,Union{I ext = "moments" end - has_data = all(length(glob(basename(p) * ".$ext*.h5", dirname(p))) > 0 + has_data = all(length(glob(basename(p) * ".$ext*.h5", dirname(p))) > 0 || + length(glob(basename(p) * ".$ext*.cdf", dirname(p))) > 0 for p ∈ run_prefixes) if !has_data println("No $ext data found for $run_prefixes, skipping $ext") From 0e2acc9571d13664c6265bbbc262c41a474c9915 Mon Sep 17 00:00:00 2001 From: John Omotani Date: Wed, 22 Nov 2023 20:00:00 +0000 Subject: [PATCH 2/3] Fix typo in makie_post_processing docs --- docs/src/post_processing_notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/post_processing_notes.md b/docs/src/post_processing_notes.md index 91b256fbd..62ed0f972 100644 --- a/docs/src/post_processing_notes.md +++ b/docs/src/post_processing_notes.md @@ -9,7 +9,7 @@ Post processing functionality is provided by the processing, call [`moment_kinetics.makie_post_processing.makie_post_process`](@ref) e.g. ```julia -julia> using moment_kinetics.makie_post_process +julia> using moment_kinetics.makie_post_processing julia> makie_post_process("runs/example-run/") ``` or From d3db3ff5ff7da8974a87480eb50ee74125b5438f Mon Sep 17 00:00:00 2001 From: John Omotani Date: Wed, 22 Nov 2023 20:00:16 +0000 Subject: [PATCH 3/3] Add pointer to multigifview in makie_post_processing docs --- docs/src/post_processing_notes.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/src/post_processing_notes.md b/docs/src/post_processing_notes.md index 62ed0f972..8633ded59 100644 --- a/docs/src/post_processing_notes.md +++ b/docs/src/post_processing_notes.md @@ -39,6 +39,12 @@ To see all the options that can be set, be used to create an example file containing all the options with their default values. The options are all commented out when the file is created. +!!! note "Viewing animations" + Animations are produced in `.gif` format. Most utilities just play gifs, + but provide no options to pause them, etc. One that provides a few more + features is [multigifview](https://github.com/johnomotani/multigifview) + (developed by @johnomotani). + Interactive use ---------------