Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce magnetic mirror physics/ generalised geometry into moment_kinetics #164

Closed
mrhardman opened this issue Nov 29, 2023 · 4 comments · Fixed by #166
Closed

Introduce magnetic mirror physics/ generalised geometry into moment_kinetics #164

mrhardman opened this issue Nov 29, 2023 · 4 comments · Fixed by #166
Assignees
Labels
enhancement New feature or request

Comments

@mrhardman
Copy link
Collaborator

To implement magnetic geometry we need to modify several features of moment_kinetics.

@johnomotani thoughts appreciated on order of developments.

@mrhardman mrhardman added the enhancement New feature or request label Nov 29, 2023
@mrhardman mrhardman self-assigned this Nov 29, 2023
@johnomotani
Copy link
Collaborator

pinging @slnewton - any thoughts?

@mrhardman
Copy link
Collaborator Author

A first attempt to generalise the treatment of the geometry is here

https://github.com/mabarnes/moment_kinetics/tree/geometry-upgrade

I have not addressed the issue #111 although the branch above would be the natural place to do this.

@mrhardman
Copy link
Collaborator Author

@slnewton @johnomotani @mabarnes In particular, it is important now to pick a sufficiently general coordinate system that I can structure the advection terms and geometry module such that we can later easily feed in results from a Grad-Shafranov solver. I am guessing that a sensible choice could be the coordinates (Z,rho,zeta), with rho = sqrt(psi/psi_0), Z the vertical distance and zeta the toroidal angle. What do present SOL codes use? We can map z -> Z, r -> rho.

@mrhardman mrhardman linked a pull request Dec 6, 2023 that will close this issue
@mrhardman
Copy link
Collaborator Author

Linking the PR just to make finding it easy - the work is still draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants