Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we move external pipelines from KFP-Tekton into the katalog? #70

Open
ckadner opened this issue Apr 27, 2022 · 0 comments
Open
Assignees
Labels
question Further information is requested

Comments

@ckadner
Copy link
Member

ckadner commented Apr 27, 2022

The catalog_upload.json file (MLX bootstrapper) pulls in some external assets.

$ curl -s https://raw.githubusercontent.com/machine-learning-exchange/mlx/main/bootstrapper/catalog_upload.json | \
    grep -E '^  "|"url":' |  grep -v "/katalog/"

  "components": 
      "url": "https://raw.githubusercontent.com/Trusted-AI/AIF360/master/mlops/kubeflow/bias_detector_pytorch/component.yaml"
      "url": "https://raw.githubusercontent.com/Trusted-AI/adversarial-robustness-toolbox/main/utils/mlops/kubeflow/robustness_evaluation_fgsm_pytorch/component.yaml"

  "pipelines": 
      "url": "https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/tests/compiler/testdata/parallel_join.yaml"
      "url": "https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/tests/compiler/testdata/sequential.yaml"
      "url": "https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/tests/compiler/testdata/resourceop_basic.yaml"


The 2 Trusted-AI components we probably want to keep in their place. The KFP-Tekton pipelines however we may want to move them into the katalog repo, especially since they are only meant to be compiler test data in KFP-Tekton.

One of the impacts the current situation, is the script that updates the README cannot get a proper name (and description) for these pipelines and it cannot (re)generate the true listing of katalog assets. So whoever runs the script needs to heed the warning which the scripts prints out and exercise some judgment before committing the changes or risk that the external asset links may have been removed unintentionally.

A better way, albeit more work, might be to have the script read the existing README file, find absolute YAML links which point outside the katalog repo, and re-inject them into the newly generated README. But that introduces more additional complexity.

/cc @animeshsingh
/cc @Tomcli

Originally posted by @ckadner in #69 (comment)

@ckadner ckadner changed the title We need to keep (some of) the external pipelines (for now). Maybe the script could print a warning that who ever runs it must exercise some judgment before committing the changes with a warning the external asset links may have been removed unintentionally. Should we move external pipelines from KFP-Tekton into the katalog? Apr 27, 2022
@ckadner ckadner added the question Further information is requested label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants