Reverse fromDay and fromTable call order in CurrencyAverageRatesService

[maciej-sz]

Currently the api requires to first call fromDay and then fromTable:

$averageRatesService->fromDay('2023-01-01')->fromTable('A');

This causes the need to iterate month tables on the spot. All tables must be iterated in order to build the TablesDictionary. This diminishes all advantages of using generator, because even if no data is actually used from those tables the full iteration of those tables takes place.

Switching the api to first call fromTable would allow to produce generators which will be called only on actual usage. Also it would not cause triggering the generator of other tables if only one table is picked.

[mkarolczyk]

Hey, are you going to solve this problem in the near future? I am only using table A, but in the last 2 months I have a constant problem because table B has "no data" at the beginning of the month. Even though I am not using table B, I am not able to retrieve the data itself from table A.

[maciej-sz]

Hey @mkarolczyk I will look into it but resolving it in a way proposed in the above description of this issue would be a huge BC break and will probably be introduced only in the next major version. There should probably be a separate fix for the situation you described.