alacritty: Fix nerdfont variant #27758
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying maintainers: |
|
LGTM, thanks for fixing this @Koston-0xDEADBEEF. Would you mind adding a comment in the Portfile to check the |
Koston-0xDEADBEEF
force-pushed
the
alacritty-15-nerd
branch
from
2cdc79c to
0a955ad
Compare
|
@akierig Sure thing, comment added. Crossfont codebase hasn't really changed in years so the patch is unlikely to break - except when a minor fix bumps the version number. |
|
Appreciate it a lot! thanks! LGTM. |
|
oh yeah you will need to bump the revision in the port file from 0 to 1 |
Koston-0xDEADBEEF
force-pushed
the
alacritty-15-nerd
branch
from
0a955ad to
2b67e21
Compare
|
Good catch, thanks! |
|
Thanks @Koston-0xDEADBEEF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alacritty variant
+nerdfontpatches alacritty dependencycrossfont, which had its version number bumped. Reflect the change in patch to fix the variant.Type(s)