Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor settings #17

Open
apoorvsadana opened this issue Jun 17, 2024 · 0 comments
Open

feat: refactor settings #17

apoorvsadana opened this issue Jun 17, 2024 · 0 comments
Assignees
@ocdbytes
Labels
mainnet mvp

Comments

@apoorvsadana
Copy link
Contributor

apoorvsadana commented Jun 17, 2024 •
edited
Loading

Refactor the with_settings usage. We need to decide how and where should we read config variables from - env or json. env is easier to to config when hosting but json is more readable. Currently, the usage of with_settings seems to be incorrect in a few places where we read an env after fetching the settings from the provider (https://github.com/karnotxyz/madara-orchestrator/blob/7baf1903b50fb52815fdf5b4e65733ec0076620d/crates/settlement-clients/ethereum/src/lib.rs#L40-L40). This seems incorrect, we need to figure out a coherent approach and implement it.
@apoorvsadana apoorvsadana changed the title feat: move important contract addresses to Config feat: refactor settings Jul 18, 2024
@apoorvsadana apoorvsadana moved this to Backlog in Madara Orchestrator Jul 18, 2024
@apoorvsadana apoorvsadana mentioned this issue Jul 19, 2024
Draft
@ocdbytes ocdbytes self-assigned this Aug 30, 2024
@ocdbytes ocdbytes mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocdbytes ocdbytes

Labels
mainnet mvp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocdbytes @apoorvsadana