Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: use core contract implementation from zaun #28

Open
akhercha opened this issue Jun 25, 2024 · 0 comments
Open

dev: use core contract implementation from zaun #28

akhercha opened this issue Jun 25, 2024 · 0 comments
Labels
mainnet mvp

Comments

@akhercha
Copy link
Member

Follow-up from this PR: keep-starknet-strange/zaun#18

Current behavior

We currently defined our own implementation of the Starknet core contract using Alloy because we could not import the one from Zaun since it uses ethers.

Expected behavior

After the alloy migration, we want to remove our own small implementation and use the one Zaun's one.
@akhercha akhercha changed the title fix: Use the starknet-core-contract-client in the Ethereum settlement client dev: Use the starknet-core-contract-client in the Ethereum settlement client Jun 25, 2024
@akhercha akhercha mentioned this issue Jun 25, 2024
Merged
@apoorvsadana apoorvsadana changed the title dev: Use the starknet-core-contract-client in the Ethereum settlement client dev: use core contract implementation from zaun Jul 18, 2024
@apoorvsadana apoorvsadana moved this to Backlog in Madara Orchestrator Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mainnet mvp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhercha @apoorvsadana