Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Ethereum Settlement Client #81

Merged
merged 45 commits into from
Aug 23, 2024
Merged

Test: Ethereum Settlement Client #81

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
84a3819
update: settlement-client: ethereum test cases for conversion fns
heemankv Aug 2, 2024
0c6d868
update: removed .expect from slice_u8_to_u256
heemankv Aug 2, 2024
f77093b
update: Eth Settlement client: tests for conversions
heemankv Aug 5, 2024
c23a4a6
update: Eth Settlement client : prepare_sidecar
heemankv Aug 5, 2024
5e2ea5e
update: settlement_client: eth: prepare_sidecar tests
heemankv Aug 5, 2024
f435b1d
chore: optimisations
heemankv Aug 6, 2024
229e50d
update: working test case
heemankv Aug 7, 2024
aa1bef2
update: working test #2
apoorvsadana Aug 7, 2024
3158c48
update: added cfg test for update_state_with_blobs
heemankv Aug 9, 2024
db1a675
update: cleaner cfg(test) implemented code for update_state_and_blob_…
heemankv Aug 9, 2024
d562e4c
chore: liniting fixes
heemankv Aug 9, 2024
69cc0b7
update: linting fixes
heemankv Aug 12, 2024
46fc944
docs: changelog
heemankv Aug 12, 2024
c6bfdce
update: Nonce prefetch for state_update
heemankv Aug 13, 2024
f3fc826
update: creation of input_data works
heemankv Aug 13, 2024
d28b98b
update: using correct input bytes
heemankv Aug 13, 2024
a03f9db
chore: lint fix
heemankv Aug 13, 2024
06d97cd
update: test normal transaction
heemankv Aug 14, 2024
5aa7b10
update: dummy contract and impersonation tests ready
heemankv Aug 14, 2024
e7023af
update: test cases for settlement client
heemankv Aug 14, 2024
391d693
chore: lint fixes
heemankv Aug 14, 2024
856fa1f
chore: fix lints
heemankv Aug 14, 2024
a03387f
Merge branch 'main' into test/settlement-client
heemankv Aug 14, 2024
6b69fdd
update: Changes for PR review
heemankv Aug 16, 2024
bbecc38
chore: fixing test cases for eth settlement client
heemankv Aug 16, 2024
01294a0
update: tests fix
heemankv Aug 16, 2024
1178e22
chore: lint fix
heemankv Aug 16, 2024
acf9738
Merge branch 'main' into test/settlement-client
heemankv Aug 16, 2024
60fac37
chore: lint fix
heemankv Aug 16, 2024
3a125ad
update: path fix
heemankv Aug 16, 2024
e2a0bed
update: testing anvil install on gh
heemankv Aug 16, 2024
92aa145
update: fixing path
heemankv Aug 16, 2024
6c03f7b
update: added Blast rpc for eth
heemankv Aug 16, 2024
a3c0863
update: Coverage CI fixes
heemankv Aug 16, 2024
d0ddfde
update: correct Pr checks
heemankv Aug 16, 2024
4de6e8b
update: PR reviews fixes
heemankv Aug 17, 2024
ebe967e
update: PR reviews fixes
heemankv Aug 17, 2024
ef35e52
update: adding rationale for update_state_blob_with_impersonation_wor…
heemankv Aug 17, 2024
a8f4bb1
update: cleaner test integration on update_state_with_blobs
heemankv Aug 18, 2024
30e8584
update: removing EthProvider
heemankv Aug 18, 2024
ef5a562
Reworking Settlement Client Changes (#89)
apoorvsadana Aug 20, 2024
6b7a656
Merge branch 'main' into test/settlement-client
heemankv Aug 23, 2024
8e9c13d
Merge branch 'main' into test/settlement-client
heemankv Aug 23, 2024
b93372e
update PR reviews fixed
heemankv Aug 23, 2024
f9d3682
update PR reviews fixed
heemankv Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,7 @@ SQS_JOB_VERIFICATION_QUEUE_URL=
# S3
AWS_S3_BUCKET_NAME=
AWS_S3_BUCKET_REGION=

# Ethereum Settlement
DEFAULT_SETTLEMENT_CLIENT_RPC=
DEFAULT_L1_CORE_CONTRACT_ADDRESS=
9 changes: 8 additions & 1 deletion .env.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ MADARA_RPC_URL="http://localhost:3000"
ETHEREUM_RPC_URL="http://localhost:3001"
MEMORY_PAGES_CONTRACT_ADDRESS="0x000000000000000000000000000000000001dead"
PRIVATE_KEY="0xdead"
ETHEREUM_PRIVATE_KEY="0x000000000000000000000000000000000000000000000000000000000000beef"
ETHEREUM_PRIVATE_KEY="0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you okay with this being public? If this is not a problem, document why this is set in Github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we can remove this but it's genuinely no harm since this is Private_key provided by Anvil, will add a comment to explain the same

STARKNET_SOLIDITY_CORE_CONTRACT_ADDRESS="0x000000000000000000000000000000000002dead"

##### Config URLs #####
Expand All @@ -25,3 +25,10 @@ PROVER_SERVICE="sharp"
SETTLEMENT_LAYER="ethereum"
DATA_STORAGE="s3"
MONGODB_CONNECTION_STRING="mongodb://localhost:27017"


# Ethereum Settlement
DEFAULT_SETTLEMENT_CLIENT_RPC="http://localhost:3000"
DEFAULT_L1_CORE_CONTRACT_ADDRESS="0xc662c410C0ECf747543f5bA90660f6ABeBD9C8c4"
TEST_IMPERSONATE_OPERATOR="1"
TEST_DUMMY_CONTRACT_ADDRESS="0xE5b6F5e695BA6E4aeD92B68c4CC8Df1160D69A81"
14 changes: 14 additions & 0 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,20 @@ jobs:
- uses: taiki-e/install-action@cargo-llvm-cov
- uses: taiki-e/install-action@nextest

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1

- name: Check Anvil Installation
run: |
if command -v anvil &> /dev/null
then
echo "Anvil is installed. Version information:"
anvil --version
else
echo "Anvil is not installed or not in PATH"
exit 1
fi

- name: Clean workspace
run: |
cargo llvm-cov clean --workspace
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## Added

- Tests for Settlement client.
- added coveralls support
- moved mongodb serde behind feature flag
- implemented DA worker.
Expand Down
Loading
Loading