Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): set max number of websocket connections #341

Open
1 task done
Tracked by #335
Trantorian1 opened this issue Oct 15, 2024 · 0 comments
Open
1 task done
Tracked by #335

feat(ws): set max number of websocket connections #341

Trantorian1 opened this issue Oct 15, 2024 · 0 comments
Labels
help wanted Extra attention is needed rpc-0.8.0 Implementation of the new rpc specs

Comments

@Trantorian1
Copy link
Collaborator

Trantorian1 commented Oct 15, 2024

Is there an existing issue?

  • I have searched the existing issues

Motivation

See #335 for more information about implementing rpc v0.8.0-rc0 in Madara.

Request

Add a cmd-line option to set the max number of websocket connections allowed in Madara, with the option for unlimited connections (defaults to a finite number of connections).

Note

Madara already provides the --rpc-max-request-size but this does not limit the number of ws connections, only their size.

Solution

Solution should be integrated into a separate param struct along with other websocket rpc arguments. See #342 and #343 for more information.

Are you willing to help with this request?

Yes!

@Trantorian1 Trantorian1 added help wanted Extra attention is needed rpc-0.8.0 Implementation of the new rpc specs labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed rpc-0.8.0 Implementation of the new rpc specs
Projects
None yet
Development

No branches or pull requests

1 participant