Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc): migrate rpc types from starknet-rs to types-rs #382

Closed
1 task done
jbcaron opened this issue Nov 14, 2024 · 0 comments · Fixed by #395
Closed
1 task done

refactor(rpc): migrate rpc types from starknet-rs to types-rs #382

jbcaron opened this issue Nov 14, 2024 · 0 comments · Fixed by #395
Assignees
Labels
feature Request for new feature or enhancement

Comments

@jbcaron
Copy link
Member

jbcaron commented Nov 14, 2024

Is there an existing issue?

  • I have searched the existing issues

Motivation

  • custom types are currently used for all database-stored data due to the reliance on bincode and serde for serialization
  • types-rs is already utilized for felt, ensuring consistency and optimized serialization, as it aligns with other dependencies that also use this felt type
  • for the feeder, we still rely on custom types since starknet-rs does not handle all serialization cases
  • however, all RPCs currently depend on starknet-rs

Request

transition the starknet-rs RPC types to types-rs to achieve uniformity, streamline serialization, and reduce dependency complexity

for reference, see the starknet-types-rpc crate

Solution

No response

Are you willing to help with this request?

No.

@jbcaron jbcaron added the feature Request for new feature or enhancement label Nov 14, 2024
@jbcaron jbcaron added this to Madara Nov 14, 2024
@jbcaron jbcaron changed the title ref(rpc): migrate rpc types from starknet-rs to types-rs refactor(rpc): migrate rpc types from starknet-rs to types-rs Nov 14, 2024
@jbcaron jbcaron self-assigned this Nov 19, 2024
@jbcaron jbcaron moved this to In progress in Madara Nov 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Madara Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for new feature or enhancement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant